This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 11/12] ldbl-128ibm-compat: Redirect complex math functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>, Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>
- Date: Wed, 20 Jun 2018 21:00:01 +0000
- Subject: Re: [PATCH 11/12] ldbl-128ibm-compat: Redirect complex math functions
- References: <20180620020426.20372-1-tuliom@linux.ibm.com> <20180620020426.20372-12-tuliom@linux.ibm.com>
I don't see any test infrastructure in this patch series for either the
math.h or complex.h functions. Is that to be added separately?
Principles include:
* As ulps are currently identified as "ldouble" and "float128", those need
to be appropriately associated with the correct formats in testing (which
the testing already handles for getting _FloatN tests using the
appropriate ulps, whatever type name those ulps may be listed with).
* The libm functions built for each format should be tested. While most
of the functions built for float128 are at least tested under their *f128
names, you have those such as __significandieee128 which don't have such a
name and so need testing added for the code to get tested at all.
* There should be at least some test coverage that the redirection works,
i.e. tests built and run with binary128 long double.
--
Joseph S. Myers
joseph@codesourcery.com