This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve DST handling (Bug 23102, Bug 21942, Bug 18018, Bug, 23259, CVE-2011-0536 ).

On Jun 11 2018, Carlos O'Donell <carlos@redhat.com> wrote:

> By validating it against the abstract definition of the ELF gABI spec 
> for a DST name it prevents any future caller from accidentally straying
> outside of that contract without having to make two changes: (1) change 
> the comparison DST and (2) change what we accept in is_dst().

Why would we add any use of is_dst with an invalid DST?  That doesn't
make sense.

> Also I find the code ends up being simpler.

I don't agree.  It is overly complex for no reason.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]