Re: [PATCH] aarch64: add HXT Phecda core memory operation ifuncs

[Siddhesh Poyarekar <siddhesh at gotplt dot org>]

On 06/12/2018 11:25 AM, Hongbo Zhang wrote:
> Thank you for the quick review.
> It is my first time to upstream a glibc patch, rules seem a bit
> different from kernel/uboot etc.
> If it is up to me to clarify the copyright, how to do it, add a
> Co-authored-by tag?

Yes, the rules are very different from kernel/uboot where the 
contributors continue to own copyright and there's typically only a 
developer sign-off to claim that copyright.  In glibc and gcc we have a 
concept of copyright assignment where we transfer ownership of code to 
the Free Software Foundation who we trust to defend our copyright in 
case of infringement.

The problem with the patch is not that of format; you have formatted the 
patch perfectly and would have been good to be committed, but we need a 
copyright assignment (i.e. an agreement that you're willing to transfer 
ownership of the copyright to this code to the FSF) from all authors of 
the patch.

Your contribution has an automatic assignment since you're a Linaro 
assignee, but that's not the case for the other author (AFAICT, again I 
don't have access to the copyrights file so I can't tell for sure, only 
the FSF stewards can) because of which we need to understand the scope 
of their contribution and their assignment status to decide on the 
future course of action on this patch.

Sorry for the trouble, but this is an unavoidable part of the patch 
review workflow.

Siddhesh