This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 02/12] nds32: ABI Implementation

From: Joseph Myers <joseph at codesourcery dot com>
To: Vincent Chen <vincentc at andestech dot com>
Cc: <libc-alpha at sourceware dot org>, <deanbo422 at gmail dot com>, <cnoize at andestech dot com>
Date: Thu, 31 May 2018 21:50:16 +0000
Subject: Re: [PATCH v2 02/12] nds32: ABI Implementation
References: <1527677142-10406-1-git-send-email-vincentc@andestech.com> <1527677142-10406-3-git-send-email-vincentc@andestech.com>

On Wed, 30 May 2018, Vincent Chen wrote:

> +typedef struct __jmp_buf_internal_tag
> +  {
> +    /* Callee-saved registers: $r6 - $r14, $fp, $gp, $lp, $sp: $r28 - $r31.  */
> +    int __regs[13];
> +  } __jmp_buf[1] __attribute__((__aligned__ (8)));

Should have a space between '__attribute__' and '(('.

> +static void __mcount_internal (u_long frompc, u_long selfpc) __attribute_used__;
> +
> +#define _MCOUNT_DECL(frompc, selfpc) \
> +static void __mcount_internal (u_long frompc, u_long selfpc)
> +
> +
> +#define MCOUNT							\
> +void _mcount (u_long frompc)		      			\
> +{								\
> +  __mcount_internal (frompc, (u_long) RETURN_ADDRESS (0));	\

As in the RISC-V port review, "unsigned long int" should be used in place 
of the legacy u_long name.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH v2 00/12] nds32 glibc port, v2
  - From: Vincent Chen
- [PATCH v2 02/12] nds32: ABI Implementation
  - From: Vincent Chen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]