Re: [PATCH v2 07/12] nds32: Linux Syscall Interface

[Joseph Myers <joseph at codesourcery dot com>]

On Wed, 30 May 2018, Vincent Chen wrote:

> +long int syscall (long int __sysno, ...)

Function return type should be on the line before the function name, in a 
function definition.

> +{
> +  int result;
> +  unsigned long arg1, arg2, arg3, arg4, arg5, arg6;
> +  va_list arg;
> +  va_start (arg, __sysno);
> +  arg1 = va_arg (arg, unsigned long);

glibc style uses "long int" and "unsigned long int" rather than plain 
"long" or "unsigned long".  There are lots of places in this patch that 
need to be fixed for this; please review the whole patch series and fix 
accordingly.

> +  result =
> +      INLINE_SYSCALL_NCS (__sysno, 6, arg1, arg2, arg3, arg4, arg5, arg6);

Lines should be split before an operator, not after.  Or in this case, 
split after some comma inside the parentheses.

-- 
Joseph S. Myers
joseph@codesourcery.com