Re: [PATCH] i386: Do not attempt to change stack alignment

[Florian Weimer <fweimer at redhat dot com>]

On 05/22/2018 02:33 PM, Andreas Schwab wrote:
> On Mai 22 2018, Florian Weimer <fweimer@redhat.com> wrote:
>
> > On 05/22/2018 12:24 PM, Andreas Schwab wrote:
> > > On Mai 22 2018, Florian Weimer<fweimer@redhat.com>  wrote:
> > >
> > > > I don't really understand what you are after
> > > > here. -mpreferred-stack-boundary=4 is the default, so the Makefile bits I
> > > > removed are just a cleanup that was missed when the (rather broken)
> > > > -mpreferred-stack-boundary=2 flag was removed.
> >
> > > My issue is that this has nothing to do with GCC, but with our (former)
> > > use of the option.  Your summary is misleading.
> >
> > Do you think this wording is an improvement?
> >
> > Thanks,
> > Florian
> >
> > Subject: [PATCH] i386: Drop -mpreferred-stack-boundary=4
> > To: libc-alpha@sourceware.org
> >
> > GCC uses it by default.
>
> I think you should just say "We no longer use
> -mpreferred-stack-boundary=2".  That was the only reason for the need to
> override it -mpreferred-stack-boundary=4.  The reference to GCC is a red
> herring.

What about this?

| i386: Drop -mpreferred-stack-boundary=4
|
| The flag was a left-over from when the -mpreferred-stack-boundary=2 flag
| was removed in commit db290cf59207aff09d1794e666e2854a93775f32.

Thanks,
Florian