This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Do not attempt to change stack alignment
On Mai 22 2018, Florian Weimer <fweimer@redhat.com> wrote:
> On 05/22/2018 12:24 PM, Andreas Schwab wrote:
>> On Mai 22 2018, Florian Weimer<fweimer@redhat.com> wrote:
>>
>>> I don't really understand what you are after
>>> here. -mpreferred-stack-boundary=4 is the default, so the Makefile bits I
>>> removed are just a cleanup that was missed when the (rather broken)
>>> -mpreferred-stack-boundary=2 flag was removed.
>
>> My issue is that this has nothing to do with GCC, but with our (former)
>> use of the option. Your summary is misleading.
>
> Do you think this wording is an improvement?
>
> Thanks,
> Florian
>
> Subject: [PATCH] i386: Drop -mpreferred-stack-boundary=4
> To: libc-alpha@sourceware.org
>
> GCC uses it by default.
I think you should just say "We no longer use
-mpreferred-stack-boundary=2". That was the only reason for the need to
override it -mpreferred-stack-boundary=4. The reference to GCC is a red
herring.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."