This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] support: Add TEST_COMPARE_BLOB, support_quote_blob

From: Florian Weimer <fweimer at redhat dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 15 May 2018 15:58:04 +0200
Subject: Re: [PATCH] support: Add TEST_COMPARE_BLOB, support_quote_blob
References: <20180302105949.E623C40454581@oldenburg.str.redhat.com> <alpine.DEB.2.20.1803021714090.29959@digraph.polyomino.org.uk>

On 03/02/2018 06:14 PM, Joseph Myers wrote:

On Fri, 2 Mar 2018, Florian Weimer wrote:

+void support_test_compare_blob (const void *left, unsigned long left_length,
+                                const void *right, unsigned long right_length,


glibc style is "unsigned long int".

+static void
+report_length (const char *what, unsigned long length, const char *expr)


Likewise in the various function definitions, of course.

Thanks, fixed locally. I need to figure out a way to implement this inmy style checker.


Florian

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]