This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] nscd: avoid assertion failure during persistent db check

From: Andreas Schwab <schwab at suse dot de>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 15 May 2018 15:45:07 +0200
Subject: Re: [PATCH] nscd: avoid assertion failure during persistent db check
References: <mvmfu2t2grx.fsf@suse.de> <54a92829-58b8-c0b3-5104-e0b632166628@redhat.com>

On Mai 15 2018, Florian Weimer <fweimer@redhat.com> wrote:

> On 05/15/2018 03:24 PM, Andreas Schwab wrote:
>> -  assert (len >= 2);
>> +  if (len < 2)
>> +    return 0;
>
> Shouldn't it log a warning at least?

The caller does.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

References:
- [PATCH] nscd: avoid assertion failure during persistent db check
  - From: Andreas Schwab
- Re: [PATCH] nscd: avoid assertion failure during persistent db check
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]