This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/2] Multiarch hooks for memcpy variants


On 14/08/17 13:14, Siddhesh Poyarekar wrote:
> Allowing a PLT only for __memcpy_chk and mempcpy would need a test case
> waiver in check_localplt and that would become a blanket OK for PLT

i only proposed plt for this specific case on
the grounds that i expect _chk to be obsoleted
and instead the check will be in user code
(which has the same semantics as if plt was
used in libc, the memcpy call is interposable)

> usage for memcpy, which we don't want.  Hence my patch is probably the
> best compromise, especially since there is precedent for the approach in
> x86.

it is probably best from performance point
of view.

but i'm not yet convinced that __memcpy_chk is
performance critical, if not, then i'd rather
not add ifuncs.

does anyone know how commonly distros build
with _FORTIFY_SOURCE?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]