This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/2] Multiarch hooks for memcpy variants


On Friday 11 August 2017 11:36 PM, Zack Weinberg wrote:
>> may be the generic __memcpy_chk should call the ifunced
>> memcpy so it goes through an extra plt indirection, but
>> at least less target specific code is needed.
> 
> I was thinking of making this suggestion myself.  I think that would
> be a better maintainability/efficiency tradeoff.  (Of course, I also
> think we shouldn't bypass ifuncs for intra-libc calls.)

That was my initial approach, but I was under the impression that PLTs
in internal calls were frowned upon, hence the ifuncs similar to what's
done in x86.  If this is acceptable, I could do more tests to check
gains within the library if we were to call memcpy via ifunc.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]