This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] i386: Increase MALLOC_ALIGNMENT to 16 [BZ #21120]

On 06/30/2017 07:54 AM, H.J. Lu wrote:
> On Thu, Jun 29, 2017 at 1:10 PM, H.J. Lu <> wrote:
>> Are you suggesting 3 i386 header files to define MALLOC_ALIGNMENT?
>> 1. generic i386.
>> 2. nptl i386.
>> 3. hurd i386.
>> That is very weird.

I hope my explanation below makes the difference clearer.

> I built and checked them for i686 with GCC 7.  The biggest challenge is to
> support GCC 7, not the header file itself.
We have an existing malloc-machine.h for this purpose.

The design question is:

(a) Should we add a new file malloc-alignment.h to specify a new parameter.
    - Adds new file malloc-alignment.h.
    - 2 new files.

(b) Should we use existing malloc-machine.h to include the new parameter?
    - Extends existing malloc-machine.h to new sysdep dirs.
    - 3 new files.

You are arguing for (a) and I argue for (b).

Use 1 less file but require a new header.
Use 1 more file but use existing headers.

I argue that it's simpler and easier for developers if we avoid additional headers
and use existing headers.

I'm open hear a comment from someone else.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]