This is the mail archive of the
mailing list for the glibc project.
Re: malloc hooks
- From: Florian Weimer <fweimer at redhat dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, libc-alpha at sourceware dot org
- Cc: nd at arm dot com
- Date: Thu, 8 Jun 2017 16:29:43 +0200
- Subject: Re: malloc hooks
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 105577D50D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 105577D50D
- References: <593953AB.firstname.lastname@example.org> <email@example.com> <59395C13.firstname.lastname@example.org>
On 06/08/2017 04:15 PM, Szabolcs Nagy wrote:
> On 08/06/17 15:05, Florian Weimer wrote:
>> On 06/08/2017 03:39 PM, Szabolcs Nagy wrote:
>>> there is some ifdef magic in malloc/hooks.c to
>>> only define malloc_get_state etc if it's needed
>>> for abi compat:
>>> #if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_25)
>>> but there is tst-mallocstate.c which uses these
>>> functions unconditionally.
>>> i wonder how that is supposed to work for new
>>> targets (e.g. aarch64 ilp32)
>> We currently do not have SHLIB_COMPAT support at the Makefile level. If
>> you have a port that bumps the compat level past 2.25, I can probably
>> come up with an implementation of that.
> is it ok to ifdef out the test code if compat level >2.25 ?
> then there is no need for makefile changes
You can try, but if I recall things correctly, SHLIB_COMPAT is not
available for !SHARED, either.