This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Tests for res_init
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Siddhesh Poyarekar <siddhesh at gotplt dot org>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 2 Jun 2017 13:19:12 -0700
- Subject: Re: [PATCH] Tests for res_init
- Authentication-results: sourceware.org; auth=none
- References: <2b4fc76e-e756-e4e4-11ca-829a03cf84bb@redhat.com> <760fae72-2aeb-fe24-541e-4a0014cce5ea@gotplt.org> <997caf1e-1676-4bbb-6739-ba27d705430a@redhat.com>
On Fri, Jun 2, 2017 at 6:49 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 05/18/2017 10:05 PM, Siddhesh Poyarekar wrote:
>> Why not just have a tst-resolv-res_init.c and
>> tst-resolv-res_init-thread.c? That's how a lot of the other similar
>> kinds of tests are rewritten. I don't have a very strong opinion on
>> this though, you can choose the color of your shed :)
>
> I do it this way so that I can use #if instead of #ifdef, following the
> current guidelines to trigger -Wundef warnings on typos.
>
> I'm going to push this without the tests expecting incorrect results.
>
On Fedora 25/x86-64, I got
[hjl@gnu-6 build-x86_64-linux]$ cat resolv/tst-resolv-res_init.out
Timed out: killed the child process
[hjl@gnu-6 build-x86_64-linux]$ cat resolv/tst-resolv-res_init-thread.out
Timed out: killed the child process
[hjl@gnu-6 build-x86_64-linux]$
--
H.J.