This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Tests for res_init
- From: Florian Weimer <fweimer at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 2 Jun 2017 15:49:56 +0200
- Subject: Re: [PATCH] Tests for res_init
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8A80861E48
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8A80861E48
- References: <2b4fc76e-e756-e4e4-11ca-829a03cf84bb@redhat.com> <760fae72-2aeb-fe24-541e-4a0014cce5ea@gotplt.org>
On 05/18/2017 10:05 PM, Siddhesh Poyarekar wrote:
> Why not just have a tst-resolv-res_init.c and
> tst-resolv-res_init-thread.c? That's how a lot of the other similar
> kinds of tests are rewritten. I don't have a very strong opinion on
> this though, you can choose the color of your shed :)
I do it this way so that I can use #if instead of #ifdef, following the
current guidelines to trigger -Wundef warnings on typos.
I'm going to push this without the tests expecting incorrect results.
Thanks,
Florian