This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 09/13] linux: Consolidate Linux vmsplice syscall


On 19/05/2017 08:24, Joseph Myers wrote:
> On Fri, 12 May 2017, Adhemerval Zanella wrote:
> 
>> 	* sysdeps/unix/sysv/linux/Makefile (CFLAGS-vmsplice.c): New flag.
> 
> This ChangeLog entry refers to CFLAGS-vmsplice.c in 
> sysdeps/unix/sysv/linux/Makefile.  However, you appear to have committed 
> an addition of CFLAGS-vmsplice.c to misc/Makefile.  That's wrong; vmsplice 
> is a Linux-specific API, not otherwise mentioned in misc/Makefile at all, 
> so the CFLAGS setting belongs in sysdeps/unix/sysv/linux/Makefile.
> 
> The same applies to splice and open_by_handle_at: when it's a sysdeps 
> Makefile that causes the source for the API to be built at all (as opposed 
> to having an ENOSYS system-independent stub and a system-independent 
> Makefile entry to build the API everywhere), all other relevant Makefile 
> settings should also be in sysdeps.
> 

Thanks for spotting it, I fixed it on 1d71a63.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]