This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 09/13] linux: Consolidate Linux vmsplice syscall

From: Joseph Myers <joseph at codesourcery dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: <libc-alpha at sourceware dot org>
Date: Fri, 19 May 2017 11:24:05 +0000
Subject: Re: [PATCH 09/13] linux: Consolidate Linux vmsplice syscall
Authentication-results: sourceware.org; auth=none
References: <1494611894-9282-1-git-send-email-adhemerval.zanella@linaro.org> <1494611894-9282-9-git-send-email-adhemerval.zanella@linaro.org>

On Fri, 12 May 2017, Adhemerval Zanella wrote:

> 	* sysdeps/unix/sysv/linux/Makefile (CFLAGS-vmsplice.c): New flag.

This ChangeLog entry refers to CFLAGS-vmsplice.c in 
sysdeps/unix/sysv/linux/Makefile.  However, you appear to have committed 
an addition of CFLAGS-vmsplice.c to misc/Makefile.  That's wrong; vmsplice 
is a Linux-specific API, not otherwise mentioned in misc/Makefile at all, 
so the CFLAGS setting belongs in sysdeps/unix/sysv/linux/Makefile.

The same applies to splice and open_by_handle_at: when it's a sysdeps 
Makefile that causes the source for the API to be built at all (as opposed 
to having an ENOSYS system-independent stub and a system-independent 
Makefile entry to build the API everywhere), all other relevant Makefile 
settings should also be in sysdeps.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH 09/13] linux: Consolidate Linux vmsplice syscall
  - From: Adhemerval Zanella

References:
- [PATCH 01/13] posix: Consolidate Linux pause syscall
  - From: Adhemerval Zanella
- [PATCH 09/13] linux: Consolidate Linux vmsplice syscall
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]