This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.

From: Zack Weinberg <zackw at panix dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, Florian Weimer <fweimer at redhat dot com>, "Carlos O'Donell" <carlos at redhat dot com>, Andreas Schwab <schwab at suse dot de>
Date: Fri, 12 May 2017 12:16:54 -0400
Subject: Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
Authentication-results: sourceware.org; auth=none
References: <20170509154103.11973-1-zackw@panix.com> <20170509154103.11973-3-zackw@panix.com> <alpine.DEB.2.20.1705092126120.28688@digraph.polyomino.org.uk> <CAKCAbMjrvYeYMAv9CSaVc+_iWvqBwD3a4nQJ4VO6q1tWuH-5xw@mail.gmail.com> <CAMe9rOrMiK8iPwu_B3fn7NQeq9=tggOe7TKqmmU+_wd_T6Z02w@mail.gmail.com>

On Fri, May 12, 2017 at 11:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>
> This patch has
>
> /* The testsuite, and some other ancillary code, should be compiled against
>    as close an approximation to the installed headers as possible.
>    Defining this symbol disables most internal-use-only declarations
>    provided by this header, and all those provided by other internal
>    wrapper headers.  */
> #if IS_IN (testsuite) || defined IS_IN_build || defined __cplusplus
> # define _ISOMAC 1
> #endif
>
> However, benchtests don't define testsuite and _ISOMAC is undefined.
> Programs in benchtests include sysdeps/generic/hp-timing-common.h
> which includes sysdeps/generic/_itoa.h which uses attribute_hidden
> attribute_hidden is defined only if _ISOMAC is undefined.  That is
> means C++ program in benchtests won't compile since
> attribute_hidden is undefined.

What is the current IS_IN value for benchtests?  Is there any reason
not to change it to 'testsuite'?

zw

Follow-Ups:
- Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
  - From: H.J. Lu

References:
- [PATCH 00/10] All of my not-yet-reviewed patches
  - From: Zack Weinberg
- [PATCH 02/10] Suppress internal declarations for most of the testsuite.
  - From: Zack Weinberg
- Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
  - From: Joseph Myers
- Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
  - From: Zack Weinberg
- Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]