This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite.
On Wed, May 10, 2017 at 4:56 AM, Zack Weinberg <zackw@panix.com> wrote:
> On Tue, May 9, 2017 at 5:28 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>>
>> The patch is OK with those changes, provided you've verified unchanged
>> installed stripped shared libraries on at least one platform (unless
>> there's some reason for the libraries to change), and an unchanged set of
>> tests run on at least one platform (except for any deliberate changes such
>> as from splitting strtod tests).
>
> Thanks. I did this verification once already, but it was long enough
> ago that I'm going to do it again, which will take another day or two.
>
This patch has
/* The testsuite, and some other ancillary code, should be compiled against
as close an approximation to the installed headers as possible.
Defining this symbol disables most internal-use-only declarations
provided by this header, and all those provided by other internal
wrapper headers. */
#if IS_IN (testsuite) || defined IS_IN_build || defined __cplusplus
# define _ISOMAC 1
#endif
However, benchtests don't define testsuite and _ISOMAC is undefined.
Programs in benchtests include sysdeps/generic/hp-timing-common.h
which includes sysdeps/generic/_itoa.h which uses attribute_hidden
attribute_hidden is defined only if _ISOMAC is undefined. That is
means C++ program in benchtests won't compile since
attribute_hidden is undefined.
--
H.J.