This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Allow [f]statfs64 to alias [f]statfs
- From: Steve Ellcey <sellcey at caviumnetworks dot com>
- To: Andreas Schwab <schwab at suse dot de>, Steve Ellcey <sellcey at cavium dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 17 Nov 2016 10:34:08 -0800
- Subject: Re: [PATCH] Allow [f]statfs64 to alias [f]statfs
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <201611072213.uA7MDcpB020773@sellcey-lt.caveonetworks.com> <mvmpolu32tn.fsf@hawking.suse.de>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Thu, 2016-11-17 at 09:53 +0100, Andreas Schwab wrote:
> On Nov 07 2016, Steve Ellcey <sellcey@cavium.com> wrote:
>
> >
> > My main question is, is this an OK use of '#ifdef' or should the
> > STATFS_IS_STATFS64 be defined on all platforms (presumably in
> > kernel_stat.h)
> > so that we can check the value instead of checking to see it is
> > defined
> > or not?
> Since it is a new symbol it should follow the policy of always being
> defined.
OK, but since having STATFS_IS_STATFS64 be handled one way
and XSTAT_IS_XSTAT64 handled a different way bothers my sense of
consistency I am going to first submit a patch to always define
XSTAT_IS_XSTAT64, then redo this patch. Hopefully a patch to always
define XSTAT_IS_XSTAT64 will be acceptable (after testing, etc).
Steve Ellcey
sellcey@caviumnetworks.com