This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Allow [f]statfs64 to alias [f]statfs
- From: Andreas Schwab <schwab at suse dot de>
- To: Steve Ellcey <sellcey at cavium dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 17 Nov 2016 09:53:08 +0100
- Subject: Re: [PATCH] Allow [f]statfs64 to alias [f]statfs
- Authentication-results: sourceware.org; auth=none
- References: <201611072213.uA7MDcpB020773@sellcey-lt.caveonetworks.com>
On Nov 07 2016, Steve Ellcey <sellcey@cavium.com> wrote:
> My main question is, is this an OK use of '#ifdef' or should the
> STATFS_IS_STATFS64 be defined on all platforms (presumably in kernel_stat.h)
> so that we can check the value instead of checking to see it is defined
> or not?
Since it is a new symbol it should follow the policy of always being
defined.
> * sysdeps/unix/sysv/linux/fstatfs64.c: Make __fstatfs and fstatfs
> aliases of __fstatfs64 if __STATFS_IS_STATFS64 is set.
> * sysdeps/unix/sysv/linux/statfs64.c: Ditto for __statfs, statfs,
> and __statfs64.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/fstatfs.c: Do not
> define __fstatfs and fstatfs if __STATFS_IS_STATFS64 is set.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/statfs.c: Ditto
> for __statfs and statfs.
It's STATFS_IS_STATFS64, not __STATFS_IS_STATFS64.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."