This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Speed up math/test-tgmath2.c


On Fri, 4 Nov 2016, Steve Ellcey wrote:

> On Fri, 2016-11-04 at 21:26 +0000, Joseph Myers wrote:
> > On Fri, 4 Nov 2016, Steve Ellcey wrote:
> > 
> > > 
> > > Here is a modified and retested patch.
> > The expression ORing together lots of function call results has 
> > indeterminate order of evaluation.  While the test should work
> > running the 
> > test functions in any order, on the whole I think it would be better
> > to 
> > make the order determinate, by doing
> > 
> > result = test_cos (vint1, vllong1);
> > result |= test_fabs (vint1, vllong1);
> > 
> > etc.
> 
> Having a determinate order of execution would make it easier when
> analyzing a failure.  Here is a new version.

This version is OK.

-- 
Joseph S. Myers
joseph@codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]