This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Speed up math/test-tgmath2.c

From: Joseph Myers <joseph at codesourcery dot com>
To: Steve Ellcey <sellcey at caviumnetworks dot com>
Cc: <libc-alpha at sourceware dot org>
Date: Fri, 4 Nov 2016 21:26:45 +0000
Subject: Re: [PATCH] Speed up math/test-tgmath2.c
Authentication-results: sourceware.org; auth=none
References: <1477354555.8523.78.camel@caviumnetworks.com> <1478280156.4630.18.camel@caviumnetworks.com> <alpine.DEB.2.20.1611041724170.25235@digraph.polyomino.org.uk> <1478293571.4630.29.camel@caviumnetworks.com>

On Fri, 4 Nov 2016, Steve Ellcey wrote:

> Here is a modified and retested patch.

The expression ORing together lots of function call results has 
indeterminate order of evaluation.  While the test should work running the 
test functions in any order, on the whole I think it would be better to 
make the order determinate, by doing

result = test_cos (vint1, vllong1);
result |= test_fabs (vint1, vllong1);

etc.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH] Speed up math/test-tgmath2.c
  - From: Steve Ellcey

References:
- Re: [PATCH] Speed up math/test-tgmath2.c
  - From: Steve Ellcey
- Re: [PATCH] Speed up math/test-tgmath2.c
  - From: Joseph Myers
- Re: [PATCH] Speed up math/test-tgmath2.c
  - From: Steve Ellcey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]