This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Yury Norov <ynorov at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>, <linux-kernel at vger dot kernel dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <marcus dot shawcroft at arm dot com>, <philb at gnu dot org>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <pinskia at gmail dot com>, <bamvor dot zhangjian at huawei dot com>, <schwab at suse dot de>, <fweimer at redhat dot com>, <Prasun dot Kapoor at cavium dot com>, <cmetcalf at mellanox dot com>, <hjl dot tools at gmail dot com>, <adhemerval dot zanella at linaro dot org>, Andrew Pinski <apinski at cavium dot com>
- Date: Tue, 28 Jun 2016 17:30:52 +0000
- Subject: Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32
- Authentication-results: sourceware.org; auth=none
- References: <1467131978-669-1-git-send-email-ynorov at caviumnetworks dot com> <1467131978-669-2-git-send-email-ynorov at caviumnetworks dot com> <alpine dot DEB dot 2 dot 20 dot 1606281657540 dot 25214 at digraph dot polyomino dot org dot uk>
On Tue, 28 Jun 2016, Joseph Myers wrote:
> On Tue, 28 Jun 2016, Yury Norov wrote:
>
> > diff --git a/sysdeps/aarch64/bits/wordsize.h b/sysdeps/aarch64/bits/wordsize.h
>
> See what I said in
> <https://sourceware.org/ml/libc-alpha/2016-06/msg00786.html> about "make
> other bits/wordsize.h files define the macro to 0". This patch would
> break all other architectures (and AArch64 LP64 - you should test build
> and testsuite for that, as well as ILP32, and confirm that there are no
> testsuite regressions for LP64).
(Actually, for LP64, if you can confirm that the installed stripped shared
libraries are byte-for-byte identical before and after the patch series,
then a testsuite run is unnecessary. But you still need to run the
testsuite for ILP32, and justify any failures there, and if the LP64
binaries aren't byte-for-byte identical, you should justify why they
aren't.)
--
Joseph S. Myers
joseph@codesourcery.com