This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v7] Add pretty printers for the NPTL lock types
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: Siddhesh Poyarekar <siddhesh at sourceware dot org>, libc-alpha at sourceware dot org, Carlos O'Donell <carlos at redhat dot com>
- Date: Wed, 8 Jun 2016 19:31:21 +0530
- Subject: Re: [PATCH v7] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <20160603181331 dot 8569-1-martin dot galvan at tallertechnologies dot com> <20160608122651 dot GA1759 at devel dot intra dot reserved-bit dot com> <CAOKbPbahEucK8Yd99OTN=Bvy5uOzpKk21BwVKiPR3qCNRufv2g at mail dot gmail dot com>
On Wed, Jun 08, 2016 at 10:36:37AM -0300, Martin Galvan wrote:
> Yeah, that's precisely what it does. I think it's good to have it like
> that because when we work on the install stage it'll only have to move
> everything from the "pretty-printers" directory in each submodule
> instead of having to do some more complex searching. But I can leave
> it in objpfx if you want.
>
> > What you're looking for is just
> > objpfx. In fact, if you set it to just current value of subdirs then
> > it should generate the file in the source directory, eliminating the
> > need to rebuild this file during every build.
>
> I don't think it's a good idea to change anything in the source dir
> when building. The only time I've had to do something like that is
> when running a bootstrap script. If anything, the pretty printers
> would have to be added to .gitignore or something.
It is quite a standard practice in glibc to generate files in the
source directory (similar to the configure script from configure.ac)
if the file is going to be mostly unchanged, which is true for your
constants file. Like the configure script, the generated file should
be added to the patch, so you don't need to added it to .gitignore.
This also means that you add a comment to the generated file saying
that it is automatically generated and it should not be modified by
hand.
Siddhesh