This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v7] Add pretty printers for the NPTL lock types

On Wed, Jun 8, 2016 at 9:26 AM, Siddhesh Poyarekar
<> wrote:
> On Fri, Jun 03, 2016 at 03:13:31PM -0300, Martin Galvan wrote:
>> +py-const-files := $(patsubst %.pysym,,$(gen-py-const-headers))
>> +py-const-dir := $(objpfx)pretty-printers/
> Does this work?  That will try to create
> $build_dir/nptl/pretty-printers/*.

Yeah, that's precisely what it does. I think it's good to have it like
that because when we work on the install stage it'll only have to move
everything from the "pretty-printers" directory in each submodule
instead of having to do some more complex searching. But I can leave
it in objpfx if you want.

> What you're looking for is just
> objpfx.  In fact, if you set it to just current value of subdirs then
> it should generate the file in the source directory, eliminating the
> need to rebuild this file during every build.

I don't think it's a good idea to change anything in the source dir
when building. The only time I've had to do something like that is
when running a bootstrap script. If anything, the pretty printers
would have to be added to .gitignore or something.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]