This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add compile testing to glibc test framework.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Tue, 7 Jun 2016 04:40:11 -0400
- Subject: Re: [PATCH] Add compile testing to glibc test framework.
- Authentication-results: sourceware.org; auth=none
- References: <575679A0 dot 4090209 at redhat dot com> <mvm1t49tpcm dot fsf at hawking dot suse dot de> <5756822F dot 8010205 at redhat dot com>
On 06/07/2016 04:13 AM, Carlos O'Donell wrote:
> On 06/07/2016 03:44 AM, Andreas Schwab wrote:
>> Carlos O'Donell <carlos@redhat.com> writes:
>>
>>> +ifeq ($(subdir),inet)
>>> +# Add tests for Linux and glibc header compatibility.
>>> +tests-compile += tst-ipv6-compat1 tst-ipv6-compat2 tst-ipv6-compat3
>>> +TEST_SRC_DIR = ../sysdeps/unix/sysv/linux/
>>
>> test-source-dir = ...
>
> Changed to 'tests-source-dir' following other plural uses of 'tests'.
>
>> How do multiple occurrences of test-compile interact with each other in
>> relation to test-source-dir?
>
> They don't work.
>
> You can't have a compile test in inet/ and one in sysdeps/unix/sysv/linux/
> which adds to inet/ without breaking the source<->test mapping for the
> inet/ test. I can document that.
>
> It's a limitation of the simplicity of the static pattern
> rule and my desire to keep the impact minimal on the build cost.
>
I also missed some of the cleanup rules, but I'll get to them in v2.
--
Cheers,
Carlos.