This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]

From: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
To: libc-alpha at sourceware dot org
Date: Thu, 14 Apr 2016 12:34:12 +0200
Subject: Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]
Authentication-results: sourceware.org; auth=none
References: <56CF62D0 dot 8060803 at redhat dot com> <56CF7D30 dot 2090000 at redhat dot com> <56DD80AF dot 3000408 at redhat dot com> <56DD9E1C dot 5030408 at redhat dot com> <56DDA516 dot 4090509 at redhat dot com> <56DDB33A dot 1000405 at redhat dot com> <56DDDF0D dot 8040601 at redhat dot com> <56FBBDE3 dot 2050106 at redhat dot com> <56FBEBED dot 6050206 at gmail dot com> <57027826 dot 4000308 at redhat dot com> <ne03t8$nla$1 at ger dot gmane dot org> <mvm37r01ap3 dot fsf at hawking dot suse dot de> <ne0k6s$f4c$1 at ger dot gmane dot org>

On 04/05/2016 05:05 PM, Stefan Liebler wrote:

On 04/05/2016 02:50 PM, Andreas Schwab wrote:

Stefan Liebler <stli@linux.vnet.ibm.com> writes:

diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c
index baada9e..fb2a763 100644
--- a/stdio-common/printf_fp.c
+++ b/stdio-common/printf_fp.c
@@ -1248,8 +1248,8 @@ ___printf_fp_l (FILE *fp, locale_t loc,
    }
    return done;
  }
-ldbl_hidden_def (___printf_fp_l, __printf_fp_l)
-ldbl_strong_alias (___printf_fp_l, __printf_fp_l)
+libc_hidden_def (__printf_fp_l)
+strong_alias (___printf_fp_l, __printf_fp_l)


Please rename ___printf_fp_l to __printf_fp_l, no need for the alias.
Otherwise looks ok.

Andreas.

Here is an updated patch to reflect the mentioned changes.
Okay to commit?

ChangeLog:

2016-04-05  Stefan Liebler  <stli@linux.vnet.ibm.com>

     * stdio-common/printf_fp.c (__printf_fp_l):
     Rename ___printf_fp_l to __printf_fp_l and
     remove strong alias. Use libc_hidden_def instead
     of ldbl_hidden_def macro.

Commited

References:
- Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]
  - From: Florian Weimer
- Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]
  - From: Stefan Liebler
- Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]
  - From: Andreas Schwab
- Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]
  - From: Stefan Liebler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]