This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] BZ #19590: Fixed build of shared objects that use functions

On Wed, Feb 17, 2016 at 7:22 AM, Andrew Senkevich
<> wrote:
> 2016-02-17 18:04 GMT+03:00 H.J. Lu <>:
>> On Wed, Feb 17, 2016 at 6:37 AM, Andrew Senkevich
>> <> wrote:
>>> 2016-02-17 17:29 GMT+03:00 H.J. Lu <>:
>>>> On Wed, Feb 17, 2016 at 6:14 AM, Andrew Senkevich
>>>> <> wrote:
>>>>> 2016-02-16 16:49 GMT+03:00 Joseph Myers <>:
>>>>>> On Tue, 16 Feb 2016, Andrew Senkevich wrote:
>>>>>>> Here is patch with tests.
>>>>>> This is the wrong approach for tests.  Tests for this should not be
>>>>>> testing implementation details about aliases, and so should not be
>>>>>> creating any wrappers at all.  They should be testing vectorizable calls
>>>>>> to the scalar functions, compiled several times with different options
>>>>>> into both executables and shared libraries.
>>>>> Please look at attached version.
>>>> There may be 2 issues:
>>>> 1. GCC 4.X may not support pragma simd.
>>>> 2. GCC X may call those aliases.
>>>> I think test-libmvec-alias-mod.c should be in assembly.
>>> For 1. we use -Wno-unknown-pragmas in make rules.
>> Then those tests will be skipped.
>>>> 2. GCC X may call those aliases.
>>> Do you mean GCC X may don't call those aliases?
>>> Yes, but then it will use not alias version and test will be also work.
>> Then those tests aren't effective for GCC X.
> But it looks enough suitable, if compiler can't generate alias name no
> needed to test that alias. Non alias name will be used.
> We can add other vector functions to this test also to test all of
> them, not only versions with aliases.

GCC used for glibc build != GCC used with glibc and differet
GCC can be used to build glibc.  If we can't reliably test glibc
with all GCC supported for glibc build, we should skip the test.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]