This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: increasing default timeout significantly

On 01/20/2016 02:35 PM, Mike Frysinger wrote:
> On 20 Jan 2016 09:55, Andreas Schwab wrote:
>> Mike Frysinger <> writes:
>>> On 19 Jan 2016 23:45, Andreas Schwab wrote:
>>>> Mike Frysinger <> writes:
>>>>> now, if you mean "you should delete the #define TIMEOUT from all tests
>>>>> whose value is <=20", then yes, that's a cleanup that i'd probably do.
>>>>> but i wasn't going to bother updating >=50 files if we didn't want to
>>>>> accept the fundamental change i posted above.
>>>> That should have been part of the original submission.
>>> i disagree.
>> Without it we cannot be sure that you thought about the implications of
>> your patch.  That is important to know.
> sorry, but this just sounds hand wavey.  with my changes, the test results are
> the same.  as others have noted, they're already using very large timeout vars
> which means in practice, we're setting the timeout to minutes/hours/longer.

I agree with Mike here. I see no technical reason why you can't raise the
default timeout. Review of existing tests that set the timeout to a specific
value is an orthogonal fix.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]