This is the mail archive of the
mailing list for the glibc project.
Re: increasing default timeout significantly
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>, libc-alpha at sourceware dot org
- Date: Wed, 20 Jan 2016 15:14:03 -0500
- Subject: Re: increasing default timeout significantly
- Authentication-results: sourceware.org; auth=none
- References: <20160119211840 dot GJ14840 at vapier dot lan> <87r3hdxm2r dot fsf at igel dot home> <20160119222646 dot GL14840 at vapier dot lan> <87mvs1xk72 dot fsf at igel dot home> <20160119225028 dot GN14840 at vapier dot lan> <mvmvb6omxyj dot fsf at hawking dot suse dot de> <20160120193552 dot GD14840 at vapier dot lan>
On 01/20/2016 02:35 PM, Mike Frysinger wrote:
> On 20 Jan 2016 09:55, Andreas Schwab wrote:
>> Mike Frysinger <firstname.lastname@example.org> writes:
>>> On 19 Jan 2016 23:45, Andreas Schwab wrote:
>>>> Mike Frysinger <email@example.com> writes:
>>>>> now, if you mean "you should delete the #define TIMEOUT from all tests
>>>>> whose value is <=20", then yes, that's a cleanup that i'd probably do.
>>>>> but i wasn't going to bother updating >=50 files if we didn't want to
>>>>> accept the fundamental change i posted above.
>>>> That should have been part of the original submission.
>>> i disagree.
>> Without it we cannot be sure that you thought about the implications of
>> your patch. That is important to know.
> sorry, but this just sounds hand wavey. with my changes, the test results are
> the same. as others have noted, they're already using very large timeout vars
> which means in practice, we're setting the timeout to minutes/hours/longer.
I agree with Mike here. I see no technical reason why you can't raise the
default timeout. Review of existing tests that set the timeout to a specific
value is an orthogonal fix.