This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: increasing default timeout significantly


On 20 Jan 2016 09:55, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
> > On 19 Jan 2016 23:45, Andreas Schwab wrote:
> >> Mike Frysinger <vapier@gentoo.org> writes:
> >> > in what way ?  there are really only three states:
> >> >  - test doesn't set a timeout
> >> >    - a passing test doesn't care if you timeout in 2 sec or 1 year
> >> >    - a failing test would take longer to timeout now, but that test
> >> >      should already be logged, and i don't think this should affect
> >> >      the default to the detriment of the common case & valid systems
> >> >  - test sets a higher timeout
> >> >    - the custom timeout is still used
> >> >    - behavior is unchanged
> >> >  - test sets a lower timeout
> >> >    - the custom timeout is still used
> >> >    - behavior is unchanged
> >> >
> >> > now, if you mean "you should delete the #define TIMEOUT from all tests
> >> > whose value is <=20", then yes, that's a cleanup that i'd probably do.
> >> > but i wasn't going to bother updating >=50 files if we didn't want to
> >> > accept the fundamental change i posted above.
> >> 
> >> That should have been part of the original submission.
> >
> > i disagree.
> 
> Without it we cannot be sure that you thought about the implications of
> your patch.  That is important to know.

sorry, but this just sounds hand wavey.  with my changes, the test results are
the same.  as others have noted, they're already using very large timeout vars
which means in practice, we're setting the timeout to minutes/hours/longer.
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]