This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Avoid redundant shift character in iconv output at block boundary (bug 17197)

On 12/14/2015 01:46 AM, Andreas Schwab wrote:
Martin Sebor <> writes:

Great, thank you for confirming that.  Will you be committing
the patch sometime soon or is something standing in the way?

Lack of review.

Yes, I see you submitted the patch for review a number of times with
no response.

For what it's worth, I've reviewed and successfully tested the patch.

I don't know the glibc commit process well enough to tell if someone
else needs to review and approve it and who that might be in this
case.  However, based on my reading of the Consensus page on the wiki
I would expect anyone to be able to commit this patch with only no
approval (I don't see the iconvdata component mentioned on in the
Reviewers by component section on the MAINTAINERS page):

  Anyone can commit a locale related change where a bugzilla issue
  exists, government sources are cited, common uses are cited, and
  if there is an original author for the locale, that original author
  ACKs the change. No developer review required. Post the patch and
  ChangeLog to libc-alpha with a short message and then push the

Do you agree it's sufficient to go ahead with the commit or do you
think someone else needs to review and approve the patch?  If the
latter, do you know who that might be?

Incidentally, while searching for more background on this bug I
came across a commit from 2014 of the same patch into the openSUSE

If another review is required, hopefully that will help increase
confidence in the patch so that it can be approved for commit here.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]