This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cleanup ARM ioperm implementation

On 2015-12-12 00:06, Arnd Bergmann wrote:
> On Friday 11 December 2015 23:32:51 Aurelien Jarno wrote:
> > Since GLIBC requires a minimum 2.6.32 kernel, the patch cleanups
> > the ARM ioperm by removing pre-2.4.23 kernel support.
> > ---
> >  ChangeLog                            |  9 +++++++++
> >  sysdeps/unix/sysv/linux/arm/ioperm.c | 11 ++---------
> >  2 files changed, 11 insertions(+), 9 deletions(-)
> The patch looks fine, but I found something else about the code here:
> I notice that the contents of that file only deal with a single ARMv4
> platform, and very few of those machines are still in use with
> new software.
> Would it make sense to build this code only when targeting an ARMv4
> system, as opposed to ARMv5 or ARMv7?

The functions provided by this file (ioperm, iopl, in{b,w,l} and
out{b,w,l}) are part of the ABI and can't be removed. If we don't compile
this file, we should at least provide stubs functions which always fail.

Note also that the libc configure script currently does not try to detect
anything below ARMv6 and considers everything below it as "default".

Aurelien Jarno                          GPG: 4096R/1DDD8C9B       

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]