This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [BZ #19178] Add a test for prelink output
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Szabolcs Nagy <nsz at port70 dot net>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 10 Nov 2015 21:43:13 +0000
- Subject: Re: [PATCH] [BZ #19178] Add a test for prelink output
- Authentication-results: sourceware.org; auth=none
- References: <20151107145502 dot GA959 at intel dot com> <20151107155458 dot GF8500 at port70 dot net> <CAMe9rOpR8mimKYCbn5ZE60PwT1W-zR7NLKibpyND=wQE9UWr6Q at mail dot gmail dot com> <CAMe9rOqKfWtQYOrRmpGS0RVpeLHNfFP=nK7Y3dK4qJdwjUXjuw at mail dot gmail dot com>
On Tue, 10 Nov 2015, H.J. Lu wrote:
> On Mon, Nov 9, 2015 at 6:42 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > On Sat, Nov 7, 2015 at 7:54 AM, Szabolcs Nagy <nsz@port70.net> wrote:
> >> * H.J. Lu <hongjiu.lu@intel.com> [2015-11-07 06:55:02 -0800]:
> >>> This test applies to i386 and x86_64 which set R_386_GLOB_DAT and
> >>> R_X86_64_GLOB_DAT to ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA. OK for
> >>> master?
> >>>
> >>
> >> why is the test x86 specific?
> >>
> >> extern protected data handling and LD_TRACE_PRELINKING
> >> seem to be generic.
> >
> > It only applies to GLOB_DAT relocation. Not all targets have it
> > and I have only x86 to test.
> >
>
> I will check it in and backport the fix with this this to 2.22 branch.
I see no sign of consensus for an x86-specific test here. I too think the
test should be written in an architecture-independent way, with a way for
architectures for which it is inapplicable to disable it.
Stop committing patches that do not have consensus, whether through
discussion or through being one of the kinds of changes listed at
<https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes>.
Write access is granted only on the basis that people will understand and
work in accordance with agreed policies for use of the repository.
--
Joseph S. Myers
joseph@codesourcery.com