This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Allow tests-special to be marked as UNSUPPORTED.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, Roland McGrath <roland at hack dot frob dot com>
- Date: Thu, 29 Oct 2015 13:30:18 +0100
- Subject: Re: [PATCH] Allow tests-special to be marked as UNSUPPORTED.
- Authentication-results: sourceware.org; auth=none
- References: <55E49599 dot 2050200 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1508311950260 dot 18606 at digraph dot polyomino dot org dot uk>
On 08/31/2015 09:55 PM, Joseph Myers wrote:
> On Mon, 31 Aug 2015, Carlos O'Donell wrote:
>
>> +# The tests-special-unsupported target lives in Makefile because there are
>> +# top-level tests in Makefile, and one or more of those top-level tests should
>> +# be unsupported in some configurations, and Rules can't be included here due
>> +# to ordering. A better solution would be to move all tests-special tests out
>> +# of the top-level and into subdirs and move this rule into Rules with the
>> +# matching tests-unsupported target.
>
> As far as I know c++-types-check.out is the only top-level test there
> might be a reason to make conditional like this, and moving it to a
> subdirectory (misc/ unless there's anything obviously better) would
> probably be a patch smaller than the comments you're adding about the
> issue.
I tried this. Even in subdirectories, I couldn't get tests-special to
work with tests-unsupported. I couldn't find any examples which used
tests-special in conjunction with tests-unsupported, either.
So it seems that Carlos' original patch is in fact the simplest approach.
Florian