This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Allow tests-special to be marked as UNSUPPORTED.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, Roland McGrath <roland at hack dot frob dot com>
- Date: Thu, 29 Oct 2015 12:57:06 +0000
- Subject: Re: [PATCH] Allow tests-special to be marked as UNSUPPORTED.
- Authentication-results: sourceware.org; auth=none
- References: <55E49599 dot 2050200 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1508311950260 dot 18606 at digraph dot polyomino dot org dot uk> <5632115A dot 2030400 at redhat dot com>
On Thu, 29 Oct 2015, Florian Weimer wrote:
> I tried this. Even in subdirectories, I couldn't get tests-special to
> work with tests-unsupported. I couldn't find any examples which used
> tests-special in conjunction with tests-unsupported, either.
>
> So it seems that Carlos' original patch is in fact the simplest approach.
I think there are two separate issues:
(a) Marking tests-special unsupported.
(b) Marking top-level tests unsupported.
For (a), we may need something like Carlos's patch, but with the rules in
the correct places for subdirectory tests, rather than having long
comments to justify them being in the wrong place. (I have not reviewed
the substance of Carlos's patch to see if, with things moved, it would be
the right approach.)
For (b), the tests in question should be moved to subdirectories so that
(a) works for them.
What I don't want is any additional infrastructure related to top-level
tests, when top-level tests themselves are deprecated. If any extra
infrastructure is needed for a top-level test, that test should be moved
to a subdirectory, and then any infrastructure added in the subdirectory
context.
--
Joseph S. Myers
joseph@codesourcery.com