This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Allow tests-special to be marked as UNSUPPORTED.


On Thu, 29 Oct 2015, Florian Weimer wrote:

> I tried this.  Even in subdirectories, I couldn't get tests-special to
> work with tests-unsupported.  I couldn't find any examples which used
> tests-special in conjunction with tests-unsupported, either.
> 
> So it seems that Carlos' original patch is in fact the simplest approach.

I think there are two separate issues:

(a) Marking tests-special unsupported.

(b) Marking top-level tests unsupported.

For (a), we may need something like Carlos's patch, but with the rules in 
the correct places for subdirectory tests, rather than having long 
comments to justify them being in the wrong place.  (I have not reviewed 
the substance of Carlos's patch to see if, with things moved, it would be 
the right approach.)

For (b), the tests in question should be moved to subdirectories so that 
(a) works for them.

What I don't want is any additional infrastructure related to top-level 
tests, when top-level tests themselves are deprecated.  If any extra 
infrastructure is needed for a top-level test, that test should be moved 
to a subdirectory, and then any infrastructure added in the subdirectory 
context.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]