This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix BZ 19165 -- overflow in fread / fwrite
- From: Siddhesh Poyarekar <sid at reserved-bit dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Mon, 26 Oct 2015 12:20:15 +0530
- Subject: Re: [patch] Fix BZ 19165 -- overflow in fread / fwrite
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobOpSFwNOqD2RbsSQ95+16=xWN=fTpDJZqgPGJPSXCDmEA at mail dot gmail dot com>
On Monday 26 October 2015 09:19 AM, Paul Pluzhnikov wrote:
> Attached patch fixes BZ 19165 by failing fwrite when the byte count is
> impossibly large, and by returning actual count from fread, instead of
> approximation of it. Tested on Linux/x86_64, no new failures.
>
>
> 2015-10-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> [BZ #19165]
> * libio/iofread.c (_IO_fread): Return correct count.
> * ibio/iofread_u.c (__fread_unlocked): Likewise.
> * libio/iofwrite.c (_IO_fwrite): Error on overflow.
> * libio/iofwrite_u.c (fwrite_unlocked): Likewise.
Looks OK to me.
Siddhesh