This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[patch] Fix BZ 19165 -- overflow in fread / fwrite

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: GLIBC Devel <libc-alpha at sourceware dot org>
Date: Sun, 25 Oct 2015 20:49:30 -0700
Subject: [patch] Fix BZ 19165 -- overflow in fread / fwrite
Authentication-results: sourceware.org; auth=none

Greetings,

Attached patch fixes BZ 19165 by failing fwrite when the byte count is
impossibly large, and by returning actual count from fread, instead of
approximation of it. Tested on Linux/x86_64, no new failures.


2015-10-25  Paul Pluzhnikov  <ppluzhnikov@google.com>

        [BZ #19165]
        * libio/iofread.c (_IO_fread): Return correct count.
        * ibio/iofread_u.c (__fread_unlocked): Likewise.
        * libio/iofwrite.c (_IO_fwrite): Error on overflow.
        * libio/iofwrite_u.c (fwrite_unlocked): Likewise.

-- 
Paul Pluzhnikov

Attachment: bz19165-20151025.txt
Description: Text document

Follow-Ups:
- Re: [patch] Fix BZ 19165 -- overflow in fread / fwrite
  - From: Siddhesh Poyarekar
- Re: [patch] Fix BZ 19165 -- overflow in fread / fwrite
  - From: Florian Weimer
- Re: [patch] Fix BZ 19165 -- overflow in fread / fwrite
  - From: Andreas Schwab
- Re: [patch] Fix BZ 19165 -- overflow in fread / fwrite
  - From: Joseph Myers
- Re: [patch] Fix BZ 19165 -- overflow in fread / fwrite
  - From: Alexander Cherepanov
- Re: [patch] Fix BZ 19165 -- overflow in fread / fwrite
  - From: Rich Felker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]