This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 00/13] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- From: Florian Weimer <fweimer at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Thu, 8 Oct 2015 15:08:27 +0200
- Subject: Re: [PATCH 00/13] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- Authentication-results: sourceware.org; auth=none
- References: <1444234995-9542-1-git-send-email-adhemerval dot zanella at linaro dot com> <alpine dot DEB dot 2 dot 10 dot 1510071645260 dot 29388 at digraph dot polyomino dot org dot uk> <5615635F dot 5030306 at linaro dot org> <20151007210127 dot A30C02C39DF at topped-with-meat dot com>
On 10/07/2015 11:01 PM, Roland McGrath wrote:
>> My mistake, I have it changed in the initial cover letter, but I forgot
>> to re-add when I had to rewrite it. And my understanding is for ILP32
>> sizeof(long int) is the same as the sizeof(void*).
>
> No reason to assume that. Use uintptr_t.
This type still wouldn't be correct if we ever end up with a 32-on-64
platform which is mostly implemented in userspace. It would have 32-bit
function pointers, but the vdso page would still be outside the first 4
GiB of the address space.
We can use a typedef to the right type once the need arises for it, though.
Florian