This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 00/13] nptl: Fix Race conditions in pthread cancellation (BZ#12683)


On 10/07/2015 11:01 PM, Roland McGrath wrote:
>> My mistake, I have it changed in the initial cover letter, but I forgot
>> to re-add when I had to rewrite it.  And my understanding is for ILP32
>> sizeof(long int) is the same as the sizeof(void*).
> 
> No reason to assume that.  Use uintptr_t.

This type still wouldn't be correct if we ever end up with a 32-on-64
platform which is mostly implemented in userspace.  It would have 32-bit
function pointers, but the vdso page would still be outside the first 4
GiB of the address space.

We can use a typedef to the right type once the need arises for it, though.

Florian



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]