This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 00/13] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 7 Oct 2015 15:24:31 -0300
- Subject: Re: [PATCH 00/13] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- Authentication-results: sourceware.org; auth=none
- References: <1444234995-9542-1-git-send-email-adhemerval dot zanella at linaro dot com> <alpine dot DEB dot 2 dot 10 dot 1510071645260 dot 29388 at digraph dot polyomino dot org dot uk>
On 07-10-2015 13:48, Joseph Myers wrote:
> On Wed, 7 Oct 2015, Adhemerval Zanella wrote:
>
>> 3. Create a function to get current IP address based on ucontext_t:
>>
>> static inline
>> long int __pthread_get_ip (const struct ucontext *uc)
>> {
>> // TODO: return current IP based on uc.
>> }
>
> What happened to the request to say PC?
> <https://sourceware.org/ml/libc-alpha/2015-09/msg00422.html>. And is this
> always long even in ILP32 cases with 64-bit registers?
My mistake, I have it changed in the initial cover letter, but I forgot
to re-add when I had to rewrite it. And my understanding is for ILP32
sizeof(long int) is the same as the sizeof(void*).
>
>> nptl: Add NPTL cases for cancellation failures cases
>> nptl: Fix testcases for new pthread cancellation mechanism
>> Mark lseek/llseek as non-cancellable
>
> Are these first three patches intended to be reviewed and go in separately
> from the rest?
>
Yes, I think they are orthogonal the new cancellation system.