This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix a buglet in malloc/mtrace.pl
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Tue, 18 Aug 2015 17:42:12 -0700
- Subject: Re: Fix a buglet in malloc/mtrace.pl
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobNA8Si_MOjapztD6aE50825MFi1csxzY0w=SZpBLThZ_A at mail dot gmail dot com> <874mk2xr5g dot fsf at igel dot home> <CALoOobNAMFKaXX6pemAeeAG97s6+M=dMuNiqmU6s+DJ-dpAZMQ at mail dot gmail dot com>
On Fri, Aug 14, 2015 at 8:00 AM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Fri, Aug 14, 2015 at 12:31 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Paul Pluzhnikov <ppluzhnikov@gmail.com> writes:
>>
>
>>> - } else {
>>> + } elsif ($allocaddr != "(nil}") {
>>
>> Can this ever be false?
>
> Oops. You are almost right: the condition above is actually never
> false (my Perl is getting rusty, one does not simply compare strings
> with != in Perl!).
> The end result is that all leak detection is suppressed :-(
>
> Corrected patch attached.
Ping?
This buglet prevents me from committing fix for BZ #18757.
Thanks,
--
Paul Pluzhnikov