This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix BZ #18660 -- overflow in getusershell

From: Paul Pluzhnikov <ppluzhnikov at gmail dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Tobias Stoeckmann <tobias at stoeckmann dot org>
Date: Tue, 18 Aug 2015 16:54:44 -0700
Subject: Re: [patch] Fix BZ #18660 -- overflow in getusershell
Authentication-results: sourceware.org; auth=none
References: <CAPC3xaqdOk4EWQJEiBLidfVxSx1iH5F9k_DTZDamkjQR1xZ3Gw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1508171058110 dot 9234 at digraph dot polyomino dot org dot uk>

On Mon, Aug 17, 2015 at 3:59 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> Since you're increasing an allocation size, don't you also need to adjust
> the check a few lines earlier for whether the allocation size calculation
> would overflow?

Thanks. Revised patch attached.

2015-08-15  Paul Pluzhnikov  <ppluzhnikov@google.com>
            Tobias Stoeckmann <tobias@stoeckmann.org>

        [BZ #18660]
        * misc/getusershell.c (initshells): Fix possible overflow.

-- 
Paul Pluzhnikov

Attachment: bz18660-20150818.txt
Description: Text document

Follow-Ups:
- Re: [patch] Fix BZ #18660 -- overflow in getusershell
  - From: Mike Frysinger

References:
- [patch] Fix BZ #18660 -- overflow in getusershell
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ #18660 -- overflow in getusershell
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]