This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #17250] Static dlopen default library search path fix

On Thu, 6 Aug 2015, Mike Frysinger wrote:

> >  Umm, thanks.  Having looked through the patch again it looks to me like I 
> > got confused with the negative `__builtin_expect' expression.  My change 
> > was not neutral as intended as it's where DF_1_NODEFLIB is *set* that the 
> > conditional executes.
> we cc-ed you on it originally ... do you not see bugzilla e-mails ?
> i'm just wondering how to address the visibility aspect.

 I checked and I still have the bugzilla e-mails in my mailbox unarchived.  
Which means I saw them and marked for later processing.  I must have lost 
them from my radar then, sorry about that.  Last autumn was hectic for me.

 In any case pinging does help, as it did this time (thanks, Andreas!).

> >  I'm not prepared to properly regression-test a change right away, but 
> > meanwhile can you try the below as a proposed fix?  Also I'm not sure 
> > offhand how to make a test case that covers this issue, but I'll be happy 
> > to accept ideas and implement them.
> two were posted to the bug.  if you use tests-static in the Makefile,
> should be fairly easy to add to the tree and check the result.

 Except that they cover the usual system-installed use case and we run our 
test suite over uninstalled libraries.  Normally that does not matter, but 
here it does.  Unless I'm missing something that is, am I?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]