This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 04 Aug 2015 21:52, Maciej W. Rozycki wrote: > On Tue, 4 Aug 2015, Andreas Schwab wrote: > > > What problem are you seeing or trying to solve? > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=17250 > > Umm, thanks. Having looked through the patch again it looks to me like I > got confused with the negative `__builtin_expect' expression. My change > was not neutral as intended as it's where DF_1_NODEFLIB is *set* that the > conditional executes. we cc-ed you on it originally ... do you not see bugzilla e-mails ? i'm just wondering how to address the visibility aspect. > I'm not prepared to properly regression-test a change right away, but > meanwhile can you try the below as a proposed fix? Also I'm not sure > offhand how to make a test case that covers this issue, but I'll be happy > to accept ideas and implement them. two were posted to the bug. if you use tests-static in the Makefile, should be fairly easy to add to the tree and check the result. -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |