This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Deprecate regexp.h
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org
- Date: Fri, 31 Jul 2015 00:57:59 -0400
- Subject: Re: [PATCH v3] Deprecate regexp.h
- Authentication-results: sourceware.org; auth=none
- References: <55B3A509 dot 8090803 at panix dot com>
On 07/25/2015 11:02 AM, Zack Weinberg wrote:
> For 2.22. Revised per discussion at
> https://sourceware.org/ml/libc-alpha/2015-07/msg00862.html and
> https://sourceware.org/ml/libc-alpha/2015-07/msg00871.html .
>
> * regexp.h: Add unconditional #warning stating that this header
> will be removed soon. Revise banner comment to match.
> (compile): Consistently use ERROR instead of RETURN to report
> errors (partial fix for bz#18681).
> * regexp.c: Don't include regexp.h. Remove some unnecessary
> declarations.
> ---
> NEWS | 8 ++++++++
> misc/regexp.c | 8 ++++----
> misc/regexp.h | 31 +++++++++++++++++--------------
> 3 files changed, 29 insertions(+), 18 deletions(-)
Looks good. I'll check this in tomorrow.
c.