This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: fix set-but-unused warning w/_STACK_GROWS_UP
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Thu, 30 Jul 2015 23:59:51 -0400
- Subject: Re: [PATCH] nptl: fix set-but-unused warning w/_STACK_GROWS_UP
- Authentication-results: sourceware.org; auth=none
- References: <1438224916-27724-1-git-send-email-vapier at gentoo dot org> <20150730041706 dot CE05A2C3B11 at topped-with-meat dot com> <20150730052537 dot GA5687 at vapier>
On 07/30/2015 01:25 AM, Mike Frysinger wrote:
> On 29 Jul 2015 21:17, Roland McGrath wrote:
>> Looks fine for post-freeze. I imagine it might be freeze-worthy as a bug
>> fix for -Werror builds on actual _STACK_GROWS_UP (is that only hppa?),
>> but you didn't mention that.
>
> it is a -Werror fix, but since only hppa currently has _STACK_GROWS_UP,
> and hppa itself doesn't build w/out patches, i'm fine leaving this for
> post freeze.
> -mike
>
OK for 2.23.
Not OK for 2.22, I don't want this to inadvertently break anything.
c.