This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Add pthread_cond_timedwaitonclock_np

On Mon, 27 Jul 2015, Mike Crowe wrote:

> > > diff --git a/nptl/tst-cond11-onclock.c b/nptl/tst-cond11-onclock.c
> > > new file mode 100644
> > > index 0000000..15b3730
> > > --- /dev/null
> > > +++ b/nptl/tst-cond11-onclock.c
> > > @@ -0,0 +1,206 @@
> > > +/* Copyright (C) 2003-2014 Free Software Foundation, Inc.
> > > +   This file is part of the GNU C Library.
> > > +   Contributed by Ulrich Drepper <>, 2003.
> > 
> > No "Contributed by" lines in new files.  2015 in copyright dates.
> I can fix that (although since it's basically a copy of tst-cond11.c I
> think that I need to keep Ulrich Drepper's notice too.)

No.  The first line of a new file, before the copyright notice, should be 
a comment describing the file's contents.  You can include "based on 
tst-cond11.c" in that comment, but the place for identifying contributors 
is the list in the manual, the NEWS file entries for major contributions, 
etc. - not comments in the sources.  (Or depending on how large the 
differences are, consider making them conditional in tst-cond11.c so that 
tst-cond11-onclock.c can just #define TEST_ONCLOCK then include 
tst-cond11.c, and avoid duplication.)

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]