This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/committed] ia64: sifaction.h: change sa_flags to an int

On 22 Jul 2015 17:28, Joseph Myers wrote:
> On Tue, 21 Jul 2015, Mike Frysinger wrote:
> > --- a/sysdeps/unix/sysv/linux/ia64/bits/sigaction.h
> > +++ b/sysdeps/unix/sysv/linux/ia64/bits/sigaction.h
> > @@ -40,7 +40,8 @@ struct sigaction
> >  #endif
> >  
> >      /* Special flags.  */
> > -    unsigned long int sa_flags;
> > +    int __glibc_reserved0;
> > +    int sa_flags;
> ia64 is little-endian in glibc - doesn't this need to be the other way 
> around to be a compatible change?

ugh, you're correct of course.  i was smoke testing via glibc tests, but
guess that's not sufficient.  irony is that i just fixed an ABI bug here
in sparc ;).

> Have you verified that (a) the kernel always ignores the high bits and (b) 
> other structure members have sufficient alignment requirements that this 
> change does not reduce the alignment requirement of the structure?

sigaction includes a pointer, so alignment should be maintained (and i've
checked -- it's still 8 bytes)

Attachment: signature.asc
Description: Digital signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]