This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH/committed] ia64: sifaction.h: change sa_flags to an int
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 22 Jul 2015 17:28:25 +0000
- Subject: Re: [PATCH/committed] ia64: sifaction.h: change sa_flags to an int
- Authentication-results: sourceware.org; auth=none
- References: <1437532880-20661-1-git-send-email-vapier at gentoo dot org>
On Tue, 21 Jul 2015, Mike Frysinger wrote:
> diff --git a/sysdeps/unix/sysv/linux/ia64/bits/sigaction.h b/sysdeps/unix/sysv/linux/ia64/bits/sigaction.h
> index 2f64f19..46d03fa 100644
> --- a/sysdeps/unix/sysv/linux/ia64/bits/sigaction.h
> +++ b/sysdeps/unix/sysv/linux/ia64/bits/sigaction.h
> @@ -40,7 +40,8 @@ struct sigaction
> #endif
>
> /* Special flags. */
> - unsigned long int sa_flags;
> + int __glibc_reserved0;
> + int sa_flags;
ia64 is little-endian in glibc - doesn't this need to be the other way
around to be a compatible change?
Have you verified that (a) the kernel always ignores the high bits and (b)
other structure members have sufficient alignment requirements that this
change does not reduce the alignment requirement of the structure?
--
Joseph S. Myers
joseph@codesourcery.com