This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Call direct system calls for socket operations

On Wed, 1 Jul 2015, Andreas Schwab wrote:

> Rajalakshmi Srinivasaraghavan <> writes:
> > If I move this new code to sysdeps/unix/sysv/linux/*.c , do you mean macro
> > __ASSUME_*_SYSCALL will be defined in
> > future in sysdeps/unix/sysv/linux/*/kernel-features.h by respective arch
> > developers based on the kernel version added?
> Yes, that's the plan.

In addition, though this is independent of the present patch:

There are a limited number of architectures using socketcall.  Rather than 
having the sysdeps/unix/sysv/linux/*.c files being the socketcall 
versions, I think it might be cleaner if those versions went in 
sysdeps/unix/sysv/linux/socketcall/ and there were appropriate Implies 
files.  Then, it would not be necessary to duplicate the syscalls.list 
entries for non-socketcall architectures (in generic/ and in the directory 
for each non-socketcall non-generic architecture).  Rather, syscalls.list 
entries for these syscalls could appear just once, probably in 
sysdeps/unix/syscalls.list but failing that in 
sysdeps/unix/sysv/linux/syscalls.list.  (Note that 
sysdeps/unix/syscalls.list has entries for some syscalls that differ, e.g. 
in the exact set of strong and weak names, from those in subdirectories of 
sysdeps/unix/sysv/linux/, so care would need to be taken about reconciling 
the differences when making any such change.)

Then, when the minimum kernel version becomes recent enough for a given 
architecture that it no longer needs to use socketcall at all because the 
relevant syscalls can just be assumed, the Implies file for that 
architecture would be removed (and if all such Implies files end up being 
removed, the socketcall directory would be removed as well).

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]